Auth0 SDK checks for null values instead of false #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it was fixed in the laravel sdk (https://github.com/auth0/laravel-auth0/blob/master/src/Auth0/Login/LaravelSessionStore.php) which version are you using? |
|
The 2.x branch (for Laravel 5.1) |
|
let me push a revision for 2.x to handle this right. I will let you know |
|
thx |
|
ps: this PR is against 2.x.x-dev so it should be able to merge right in? |
|
Sorry, I thought it was an issue! let me review it |
glena
added a commit
that referenced
this pull request
Jan 22, 2016
Auth0 SDK checks for null values instead of false
|
👏 sorry for the confusion, let me release the new revision and thanks |
|
check |
|
Thx! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Auth0 SDK checks for null values when determining if a user exists.
https://github.com/auth0/auth0-PHP/blob/2.1.2/src/Auth0.php#L276
If the default value for getting a value out of the session store is set to false
will never get executed and the user will not be logged in.