Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: errorDescription value incorrectly assigned #288

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

evansims
Copy link
Member

@evansims evansims commented May 31, 2022

Changes

This PR fixes a bug where $errorDescription is incorrectly assigned the value of $error instead of $errorDescription after an is_string() check on the variable type.

References

Resolves #287

Testing

Contributor Checklist

@evansims evansims marked this pull request as ready for review May 31, 2022 22:24
@evansims evansims requested a review from a team as a code owner May 31, 2022 22:24
@evansims evansims added this to the 7.0.1 milestone May 31, 2022
@evansims evansims merged commit 248ed56 into main Jun 2, 2022
@evansims evansims deleted the fix/error-description-assignment branch June 2, 2022 00:11
@evansims evansims mentioned this pull request Jun 2, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impossible to retrieve or output the custom deny reason (error_description)
2 participants