Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added viaRemember function to guard #306

Merged
merged 5 commits into from
Sep 14, 2022
Merged

Conversation

tonyfox-disguise
Copy link
Contributor

I've found some third-party apps like Filament use the Auth::viaRemember() when checking auth status

Changes

References

Resolves #

Testing

Contributor Checklist

I've found some third-party apps like Filament use the Auth::viaRemember() when checking auth status
@tonyfox-disguise tonyfox-disguise requested a review from a team as a code owner September 14, 2022 08:13
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Base: 13.25% // Head: 13.17% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (7adcc5e) compared to base (633f390).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #306      +/-   ##
============================================
- Coverage     13.25%   13.17%   -0.08%     
- Complexity      131      132       +1     
============================================
  Files            19       19              
  Lines           332      334       +2     
============================================
  Hits             44       44              
- Misses          288      290       +2     
Impacted Files Coverage Δ
src/Auth/Guard.php 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@evansims
Copy link
Member

Hey, @tonyfox-disguise 👋 Thanks for your contribution! I appreciate it.

  • Be sure to read and check those contributor checkboxes if you agree. 👍
  • It looks like our tooling is picking up some styling and code smell issues, if you'd be able to take a look? It looks like viaRemember may just be needing a return type and

Also, I brought in some changes from the main repo to bring your PR up to date with those, in case you need to do a pull on our local repo.

@evansims
Copy link
Member

Went ahead and made those fixes, thank you again

@evansims evansims merged commit 11e68db into auth0:main Sep 14, 2022
@evansims evansims mentioned this pull request Oct 11, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants