Conform to 5.2's Authenticatable contract #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laravel 5.2 introduced the `getAuthIdentifierName` abstract function in its Authenticatable contract, throwing an error if `AuthJWTUser` is used to authenticate.
|
looks good, I will review and merge it tomorrow. |
|
Great! Thanks so much. |
glena
added a commit
that referenced
this pull request
Jan 28, 2016
Conform to 5.2's Authenticatable contract
|
done. Hate this guy, it is not mentioned here https://laravel.com/docs/5.2/authentication#adding-custom-user-providers (The Authenticatable Contract). My bad for not checking the actual code. It is v3.0.3 Really appreciated :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Laravel 5.2 introduced the
getAuthIdentifierNameabstract function in its Authenticatable contract, throwing an error ifAuthJWTUseris used to authenticate.Auth0JWTUserjust needs its own version of this function to work properly.