Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-3716] Do not require session configuration for stateless strategies #317

Merged
merged 2 commits into from
Oct 14, 2022

Conversation

evansims
Copy link
Member

Changes

This PR restores the previous (< 7.2.0) and intended behavior of only requiring a session configuration when an appropriate stateful strategy is configured by the host application.

References

Resolves #314

Testing

Contributor Checklist

@evansims evansims added this to the 7.2.1 milestone Oct 14, 2022
@evansims evansims self-assigned this Oct 14, 2022
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Base: 9.55% // Head: 9.50% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (ccd7e8e) compared to base (66be365).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              main    #317      +/-   ##
==========================================
- Coverage     9.55%   9.50%   -0.06%     
- Complexity     201     202       +1     
==========================================
  Files           23      23              
  Lines          544     547       +3     
==========================================
  Hits            52      52              
- Misses         492     495       +3     
Impacted Files Coverage Δ
src/Auth0.php 51.21% <0.00%> (-4.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@evansims evansims marked this pull request as ready for review October 14, 2022 04:32
@evansims evansims requested a review from a team as a code owner October 14, 2022 04:32
@evansims evansims merged commit 2bdf37c into main Oct 14, 2022
@evansims evansims deleted the fix/sessions-not-required-for-api-strategies branch October 14, 2022 04:36
@evansims evansims mentioned this pull request Oct 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7.2 version requires session configuration when using API strategy
1 participant