fix: Auth0\Laravel\Cache\LaravelCachePool::createItem returning a cache miss #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even when there is a value in the cache, it was still returning a miss, which made the caching practically unusable...
Codecov ReportBase: 10.16% // Head: 10.16% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #329 +/- ##
=========================================
Coverage 10.16% 10.16%
+ Complexity 208 207 -1
=========================================
Files 23 23
Lines 551 551
=========================================
Hits 56 56
Misses 495 495
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
evansims
approved these changes
Nov 3, 2022
evansims
changed the title
|
Thanks @pkivits-litebit 👍 |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even when there is a value in the cache, it was still returning a miss, which made the caching practically unusable...