fix: legacyGuardUserMethod should use $session not $token
#365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evansims
added
the
Scope: Bug
Yup, but I'm still wrapping my head around a reliable testing strategy for this legacy behaviour. It's a little tricky for a few technical reasons, but it's something I'll circle back around too in a few days. For now, I wanted to get this fix out there as a priority, to avoid a potential break in developer integrations. |
Widcket
approved these changes
Apr 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR addresses a bug where
legacyGuardUserMethodbehaviour mistakenly consumes$tokeninstead of$sessionfor automatic logins duringuser()calls.References
Resolves #363
Testing
Tests are passing. No additions were necessary to cover this change.
Contributor Checklist