[SDK-4337] fix: Trim quote characters from around environment variable strings #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evansims
added
the
Scope: Bug
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #409 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 496 497 +1
===========================================
Files 31 31
Lines 1271 1274 +3
===========================================
+ Hits 1271 1274 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
evansims
changed the title
Widcket
approved these changes
Jun 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR resolves an issue where quote characters (
', or") are not removed from strings when pulling values fromdotenvfiles. Although these quotes are always optional, it is common practice to use them. This was previous behavior before the 7.7 configuration system improvements.References
Closes #399
Testing
Testing remains at 100%.
Contributor Checklist