Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default scope, general fixes #83

Merged
merged 3 commits into from
Oct 17, 2017
Merged

Add default scope, general fixes #83

merged 3 commits into from
Oct 17, 2017

Conversation

cocojoe
Copy link
Member

@cocojoe cocojoe commented Sep 22, 2017

Update Docs

Update Docs
@cocojoe cocojoe requested a review from glena September 22, 2017 09:05
@cocojoe
Copy link
Member Author

cocojoe commented Sep 22, 2017

@glena added a default scope, as currently out of the box it will not work for OIDC users and this is non obvious. I know profile is not recommended for non OIDC, is this an issue?

Also updated Docs, I remove the BC section as it wasn't very clear and probably not relevant to talk about auth0-PHP 1.x?

@cocojoe cocojoe closed this Sep 22, 2017
@cocojoe
Copy link
Member Author

cocojoe commented Sep 22, 2017

@glena added a default scope as in OIDC it will be broken and this is non obvious I would imagine to most users. I know profile is not recommended for non OIDC, this an issue?

@cocojoe cocojoe reopened this Sep 22, 2017
@cocojoe cocojoe changed the title Add default scope Add default scope, general fixes Sep 22, 2017
@cocojoe
Copy link
Member Author

cocojoe commented Sep 22, 2017

@glena I've went through PRs and added a few bits, so please take a look 😄

@glena glena merged commit fde1d37 into master Oct 17, 2017
@glena glena deleted the changed-default-scope branch October 17, 2017 15:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants