Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoDiscovery #91

Merged
merged 2 commits into from
Mar 8, 2018
Merged

AutoDiscovery #91

merged 2 commits into from
Mar 8, 2018

Conversation

m1guelpf
Copy link
Contributor

@m1guelpf m1guelpf commented Dec 7, 2017

This will make the package work with auto-discovery in Laravel 5.5.

Remember that you need to 🏷️ a new version of the package after merging this!

@svenluijten
Copy link

Looks like it's missing a closing bracket for the extra object?

@m1guelpf
Copy link
Contributor Author

m1guelpf commented Dec 7, 2017

@svenluijten Fixed, thank you!

@joshcanhelp joshcanhelp self-assigned this Mar 8, 2018
@joshcanhelp joshcanhelp changed the base branch from master to 5.x.x-dev March 8, 2018 17:01
@joshcanhelp
Copy link
Contributor

@m1guelpf - thanks for this! You said we need to "tag a new version," anything special about it or just a new tag? Want to make sure this gets out there correctly 👍

@joshcanhelp joshcanhelp merged commit 9c4fb7a into auth0:5.x.x-dev Mar 8, 2018
@m1guelpf m1guelpf deleted the patch-1 branch March 8, 2018 18:35
@m1guelpf
Copy link
Contributor Author

m1guelpf commented Mar 8, 2018

@joshcanhelp You just have to tag it 😄

@joshcanhelp joshcanhelp added this to the 5.1.0 milestone Mar 20, 2018
@joshcanhelp joshcanhelp mentioned this pull request Mar 20, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants