Change default settings file #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved defaults based on new clients, use env() where appropriate.
cocojoe
reviewed
Mar 15, 2018
| // 'persist_access_token' => true, | ||
| // 'persist_id_token' => true, | ||
| 'persist_user' => true, | ||
| 'persist_access_token' => false, |
There was a problem hiding this comment.
We don't want to persist the access token by default?
There was a problem hiding this comment.
I don't see a good reason to ... regardless, the default is false, as per the documentation above, so just matching that in the example config.
There was a problem hiding this comment.
That's fine, only saw the // 'persist_access_token' => true, in the diff.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved defaults based on new clients, use env() where appropriate.