fix: Added a second timeout(1) to force spinning again the event loop lap … #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and verify if the initial operation has been successful
pmalouin
approved these changes
May 9, 2022
pfreixes
reviewed
May 9, 2022
| cb(new TimeoutError(ms)); | ||
| timedout = true; | ||
| }, 1); | ||
| }, ms - 1); |
pfreixes
reviewed
May 9, 2022
|
|
||
| it('should complete with an error after timeout period', function(done) { | ||
| invokeAsync(cb(function(err, res) { | ||
| assert(err); |
There was a problem hiding this comment.
I guess that we should check that the error expected is this one [1] otherwise this could get confused with the TimeoutError....
pfreixes
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and verify if the initial operation has been successful
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
Based on the work of Jeremy Martin: https://github.com/jmar777/cb
Added a second timeout(1) to force spinning again the event loop lap and verify if the initial operation has been successful
References
Testing
Checklist
master