Erl call take if no erl config #59
Conversation
| @@ -8,6 +8,7 @@ local erl_bucket_size = tonumber(ARGV[7]) | |||
| local erl_activation_period_seconds = tonumber(ARGV[8]) | |||
| local erl_quota_amount = tonumber(ARGV[9]) | |||
| local erl_quota_expiration_epoch = tonumber(ARGV[10]) | |||
| local is_erl_enabled = ARGV[11] == "true" and true or false | |||
There was a problem hiding this comment.
just in case, this is the ternary operator in lua, similar to
condition ? true : false
| return callback(valError) | ||
| let isERLEnabledForBucket = true; | ||
| const valERLConfigError = validateConfigIsForElevatedBucket(key, bucketKeyConfig) | ||
| if (valERLConfigError) { |
There was a problem hiding this comment.
is this semantically different than going down the take() function at this point?
There was a problem hiding this comment.
sorry, i know there was a slack thread on this but I found it hard to parse 😅
There was a problem hiding this comment.
I suppose the return values are different?
There was a problem hiding this comment.
yes. If we make it go the take(), we will only be using takeElevated.lua for buckets with elevated limits configuration and we'll always depend on both scripts.
This way we'll be making sure takeElevated.lua works for both scenarios and in the future we'll be able to join them in a single method if we wish to do so.
Co-authored-by: LeweyM <36539330+LeweyM@users.noreply.github.com>
Description
This PR includes 3 minor fixes:
takeElevatedfor a bucket with no elevated configuration, it allows the call to takeElevated.lua but indicating ERL is disabled so it doesn't attempt to activate it. ItTesting
Checklist