feat:support redis username #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pubalokta
force-pushed
the
feat_support_redis_username
branch
7 times, most recently
from
1d6a131 to
17ec892
Compare
pubalokta
force-pushed
the
feat_support_redis_username
branch
from
17ec892 to
2674ce3
Compare
pubalokta
force-pushed
the
feat_support_redis_username
branch
9 times, most recently
from
399002d to
2327b57
Compare
pubalokta
force-pushed
the
feat_support_redis_username
branch
from
2327b57 to
021dcb8
Compare
LeweyM
reviewed
Jul 30, 2024
LeweyM
reviewed
Jul 30, 2024
LeweyM
reviewed
Jul 30, 2024
LeweyM
reviewed
Jul 31, 2024
package.json
Outdated
| @@ -8,7 +8,8 @@ | |||
| "url": "http://github.com/auth0/limitd-redis.git" | |||
| }, | |||
| "scripts": { | |||
| "test": "trap 'docker-compose down --remove-orphans -v' EXIT; docker-compose up -d && NODE_ENV=test nyc mocha --exit" | |||
| "test-standalone": "CLUSTERED_ENV=false NODE_ENV=test nyc mocha --exit", | |||
There was a problem hiding this comment.
I'm not a huge fan of this way of running a subset of tests.
I think a better way would be to use mocha to filter for specific test file names. Mocha accepts a glob pattern for test files.
Not tested, but something like:
Suggested change
| "test-standalone": "CLUSTERED_ENV=false NODE_ENV=test nyc mocha --exit", | |
| "test-standalone": "NODE_ENV=test nyc mocha --exit '!**/*.clustermode.tests.js,**/*.standalone.tests.js'", |
There was a problem hiding this comment.
Fixed. Did it a bit different but same idea. Thanks for the suggestion
LeweyM
previously approved these changes
Jul 31, 2024
LeweyM
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
This PR adds the ability to include the username within the optional parameters of the LimitdRedis constructor to use it when connecting to a Redis Cluster.
For Standalone Redis instances, there's no need to include the username as an attribute as we support it through the connection URI.
References
Testing
Added specific tests for the username
Introduced clustered tests, which is running the same battery of tests against a clustered environment.
This change adds test coverage for new/changed/fixed functionality
Checklist