feat: adding delta_reset_ms to TAKE and TAKEELEVATED responses #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pubalokta
changed the title
pubalokta
changed the title
ecita
previously approved these changes
Oct 7, 2024
| @@ -446,6 +450,7 @@ module.exports.tests = (clientCreator) => { | |||
| assert.ok(result.conformant); | |||
| assert.equal(result.remaining, 0); | |||
| assert.closeTo(result.reset, now / 1000 + 1800, 1); | |||
There was a problem hiding this comment.
Curious why they added an extra 1800 here (maybe because of an override?)
Wondering whether we should consider and incorporate it for delta_reset_ms assertion too
There was a problem hiding this comment.
the bucket is configured at 2 tokens per hour. As it's a sliding window it calculates it needs to add 1 token every 30 minutes (1800 secs).
And it's indirectly set in the delta_reset_ms. After the calculations, it'll be 1800 secs as well.
There was a problem hiding this comment.
I still don't fully understand why we are considering "half an hour" here. Can we :watercooler: on it after this sometime?
There was a problem hiding this comment.
Unless you have a good way to describe it in text. :D
ecita
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
Adds a new
delta_reset_msresponse attribute to TAKE and TAKEELEVATED, to indicate the number of ms until the bucket resets. Unlike theresetattribute which represents a unix timestamp, this attribute represents a delta from the current time expressed in ms in order to avoid clock skew issues.Testing
Checklist