Skip to content

Commit

Permalink
[v10] Enterprise connections don't strip domain from email #543
Browse files Browse the repository at this point in the history
  • Loading branch information
glena committed Dec 19, 2016
1 parent f8f0109 commit 8974c1d
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 5 deletions.
1 change: 1 addition & 0 deletions src/connection/enterprise.js
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ export function isHRDDomain(m, email) {
export function toggleHRD(m, email) {
if (email) {
const username = l.defaultADUsernameFromEmailPrefix(m) ? emailLocalPart(email) : email;

m = setUsername(m, username, "username", false);
m = tset(m, "hrdEmail", email);
} else {
Expand Down
8 changes: 6 additions & 2 deletions src/connection/enterprise/actions.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ import {
toggleHRD
} from '../enterprise';
import { getFieldValue, hideInvalidFields } from '../../field/index';
import { emailLocalPart } from '../../field/email';
import { logIn as coreLogIn } from '../../core/actions';
import * as l from '../../core/index';

// TODO: enterprise connections should not depend on database
// connections. However, we now allow a username input to contain also
Expand Down Expand Up @@ -49,8 +51,10 @@ function logInActiveFlow(id) {
? "username"
: "email";

const username = getFieldValue(m, usernameField);
const connection = enterpriseActiveFlowConnection(m);
const originalUsername = getFieldValue(m, usernameField);
const connection = enterpriseActiveFlowConnection(m);

const username = l.defaultADUsernameFromEmailPrefix(m) ? emailLocalPart(originalUsername) : originalUsername;

coreLogIn(id, ["password", usernameField], {
connection: connection ? connection.get("name") : null,
Expand Down
4 changes: 2 additions & 2 deletions src/connection/enterprise/hrd_screen.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ const Component = ({i18n, model}) => {
const domain = enterpriseDomain(model);

var headerText;

if (domain != null) {
headerText = i18n.html("enterpriseActiveLoginInstructions", domain);
headerText = i18n.html("enterpriseActiveLoginInstructions", domain);
} else {
headerText = i18n.html("enterpriseLoginIntructions");
}
Expand Down
2 changes: 1 addition & 1 deletion src/core/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export function setup(id, clientID, domain, options, hookRunner, emitEventFn) {
hashCleanup: options.hashCleanup === false ? false : true,
allowedConnections: Immutable.fromJS(options.allowedConnections || []),
ui: extractUIOptions(id, options),
defaultADUsernameFromEmailPrefix: !!options.defaultADUsernameFromEmailPrefix
defaultADUsernameFromEmailPrefix: options.defaultADUsernameFromEmailPrefix === false ? false : true
}));

m = i18n.initI18n(m);
Expand Down

0 comments on commit 8974c1d

Please sign in to comment.