Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove version 16 from react and react-dom dependencies #1139

Closed
wants to merge 1 commit into from

Conversation

whatrocks
Copy link

Our app still runs on React 15 but this was installing React 16 as a dependency of the auth0-lock package, causing this issue: https://reactjs.org/docs/error-decoder.html?invariant=44. From a user-perspective, this caused issues with logging in, especially when users entered an incorrect password. Removing React 16 here fixed the issue for us.

@luisrudge
Copy link
Contributor

Hi, we haven't released lock with react@16 support yet. Are you installing from github?

@whatrocks
Copy link
Author

Hi @luisrudge - we were using the version from npm and it was still installing react@16 as a dependency of your package.

To fix this, I forked this project, removed the conditional referencing react@16 in your package.json (captured in this PR), and then referenced my fork on GH in our app's package.json. It no longer installed react@16, and the problem went away.

We are using node@6.10.2 if that's helpful.

@luisrudge
Copy link
Contributor

can you please paste your package.json file (at least auth0-lock, react and react-dom entries)?
If you have react 15.6.1 ini your package.json file, it should keep it that way.

@whatrocks
Copy link
Author

"react-dom": "15.5.4",
"react": "15.5.4",
"auth0-lock": "10.18.0",

We are not on react@15.6.1

@luisrudge
Copy link
Contributor

so your package.json has a fixed version of react, right? that's pretty weird 🤔

@whatrocks
Copy link
Author

Yes we have a fixed version in our package.json

@luisrudge
Copy link
Contributor

I'll try this out with a brand new create-react-app (pointing to an old version). Are you using yarn or npm?

@whatrocks
Copy link
Author

Thanks - we're using npm@3.10.10 and node@6.10.2.

@luisrudge
Copy link
Contributor

Fixing this on #1142

@luisrudge luisrudge closed this Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants