Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when showing lock for the second time with custom select input #1448

Merged
merged 2 commits into from
Jul 26, 2018
Merged

Fix crash when showing lock for the second time with custom select input #1448

merged 2 commits into from
Jul 26, 2018

Conversation

luisrudge
Copy link
Contributor

fix #1434

joshcanhelp
joshcanhelp approved these changes Jul 26, 2018
View reviewed changes
Copy link
Contributor

@joshcanhelp joshcanhelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests 🎉

Would it be worth it to generate a beta that can be tested in that CodePen?

@luisrudge
Copy link
Contributor Author

@joshcanhelp no need, really. I could reproduce their use case locally.

@luisrudge luisrudge merged commit 7713fbc into master Jul 26, 2018
@luisrudge luisrudge deleted the fix/custom-field-select-open-crash branch July 26, 2018 17:53
@luisrudge luisrudge added this to the v11.8.1 milestone Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshcanhelp joshcanhelp joshcanhelp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v11.8.1
Development

Successfully merging this pull request may close these issues.

Select lose its options when you open the popup second time.
2 participants
@luisrudge @joshcanhelp