Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PULL_REQUEST_TEMPLATE.md #1994

Merged
merged 2 commits into from
May 12, 2021
Merged

Update PULL_REQUEST_TEMPLATE.md #1994

merged 2 commits into from
May 12, 2021

Conversation

stevehobbsdev
Copy link
Contributor

This PR updates the PR template:

  • Puts all the instruction text into HTML comments so that they have less chance of materializing on the actual PR view when it is raised
  • Removes the "github checks" and "tests pass" checklist items (the automated checks tell us this)

@stevehobbsdev stevehobbsdev added the review:tiny Tiny review label May 12, 2021
@stevehobbsdev stevehobbsdev requested a review from a team as a code owner May 12, 2021 11:23
@stevehobbsdev stevehobbsdev enabled auto-merge (squash) May 12, 2021 11:23
@stevehobbsdev stevehobbsdev merged commit 5b3e481 into master May 12, 2021
@stevehobbsdev stevehobbsdev deleted the chore/pr-template branch May 12, 2021 11:53
This was referenced Jun 6, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikprijck frederikprijck frederikprijck approved these changes

Assignees
No one assigned
Labels
review:tiny Tiny review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevehobbsdev @frederikprijck