fix: initialize reset password inside componentDidMount #2111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevehobbsdev
force-pushed
the
fix/reset-password-resolver
branch
from
d5bd71a
to
0628e8a
Compare
|
This pull request fixes 1 alert when merging 0628e8a into 1f7daec - view on LGTM.com fixed alerts:
|
Widcket
approved these changes
Apr 18, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This fixes an issue where you could never type into the email box when resetting passwords if you had a connection resolver specified, as the component would always initialize itself on re-render with the email address, which could be blank. This PR fixes that so that the initialization when using a connection resolver is done inside
componentDidMountinstead.References
Fixes #2106
Testing
Checklist