Remove absolute positioning that brakes alignment on small screens #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cristiandouce Sorry to ping, but it will be great if I can get an opinion on this. I am currently migrating our auth0 applications from lock 7 to lock 10.2 and without this (or some other fix) I have to manually override the css in our lock pages. |
|
@aouji we fixed it in master and we'll probably release it next week. Will keep this open till we release |
|
Closing this @aouji please let us know if it's still an issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The absolute positioning introduced in #597 breakes alignment as the siblings of the tabs-container do not get absolute positioning in small screens. Also since we have to go high up in the parents hierarchy to get a positioned parent, it should be better to not have the absolute positioning here. I also checked that the terms still remain beneath password:
Before:
After:
