Fix Issues with Overlay mode + signUpLink setting on a SPA #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzalaz
suggested changes
Oct 19, 2016
| @@ -2,6 +2,9 @@ import React from 'react'; | |||
| import { showLoginActivity, showSignUpActivity } from './actions'; | |||
| import * as l from '../../core/index'; | |||
| import { getScreen } from './index'; | |||
| import { | |||
| closeLock | |||
There was a problem hiding this comment.
Not sure what is the style but maybe follow the other import single line style.
| @@ -38,9 +42,16 @@ export default class LoginSignUpTabs extends React.Component { | |||
| } | |||
|
|
|||
| handleSignUpClick() { | |||
| if (this.props.signUpLink) { | |||
There was a problem hiding this comment.
Should we consider the closable property value with this or should we just ignore it?
There was a problem hiding this comment.
I don't think so, in this context there are 2 scenarios:
regular webapp: the redirection will change the entire page. It is irrelevant if lock hides or not
spa: changing the route will not force a redirection so lock keeps visible unless it is explicitly hidden (this change).
While implementing lock, you might want it to not be closable (forcing signup or login on a page?) but you will want it to hide if the user is redirected to a different signup page.
hzalaz
approved these changes
Oct 19, 2016
hzalaz
force-pushed
the
overlay-signuplink-spa
branch
from
29cab79 to
7c86efe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #619