Move state cookies to under a single cookie #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Widcket
reviewed
Aug 3, 2023
Co-authored-by: Rita Zerrizuela <zeta@widcket.com>
Widcket
approved these changes
Aug 4, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
Currently we set up to 5 cookies to verify the authentication response (state, nonce, max_age, code_verifier, response_type)
Am moving these under a single cookie to make it easier to customize the cookie name and settings to implement a solution for #1297
The same change has been done in express-openid-connect auth0/express-openid-connect#168
The change is to 2 files:
(the rest of the changes are tests)