Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent caching the /me request #233

Merged
merged 2 commits into from
Jan 11, 2021
Merged

Prevent caching the /me request #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c27767
Prevent caching the `/me` request
adamjmcgrath Jan 11, 2021
0d16d03
Merge branch 'beta' into cache-control
adamjmcgrath Jan 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/handlers/profile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ export default function profileHandler(
return;
}

res.setHeader('Cache-Control', 'no-store');
res.json(session.user);
};
}
8 changes: 8 additions & 0 deletions tests/handlers/profile.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,14 @@ describe('profile handler', () => {
expect(profile).toStrictEqual({ nickname: '__test_nickname__', sub: '__test_sub__' });
});

test('should not allow caching the profile response', async () => {
const baseUrl = await setup(withoutApi);
const cookieJar = await login(baseUrl);

const { res } = await get(baseUrl, '/api/auth/me', { cookieJar, fullResponse: true });
expect(res.headers['cache-control']).toEqual('no-store');
});

test('should throw if re-fetching with no Access Token', async () => {
const afterCallback: AfterCallback = (_req, _res, session: Session): Session => {
delete session.accessToken;
Expand Down