Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAUTH-1272]: feat(attack protection): add suspicious IP throttling endpoints support #672

Conversation

sdwvit
Copy link
Contributor

@sdwvit sdwvit commented Oct 20, 2021

Changes

Adding 2 new endpoints:

  • GET /api/v2/attack-protection/suspicious-ip-throttling

    • mng.attackProtection.getSuspiciousIpThrottlingConfig(params, callback)
    • params is always an empty {} for now, since this endpoint does not support query parameters
  • PATCH /api/v2/attack-protection/suspicious-ip-throttling

    • mng.attackProtection.updateSuspiciousIpThrottlingConfig(params, data, callback)
    • params is always an empty {} for now, since this endpoint does not support query parameters

These endpoint are not yet public, but stable and are going to be merged into a iam risk feature branch of api2 (see pr link below).

References

Screen Shot 2021-10-20 at 11 25 38 AM

Testing

  • This change was manually tested
  • This change adds unit test coverage

Checklist

@sdwvit sdwvit changed the base branch from master to iamrisk-1268 October 20, 2021 15:08
@sdwvit sdwvit changed the title [CAUTH-12xx]: feat(attack protection): add suspicious IP throttling endpoints support [CAUTH-1272]: feat(attack protection): add suspicious IP throttling endpoints support Oct 20, 2021
attack-protection.tests.js:
- add suspicious IP throttling endpoints + tests
@sdwvit sdwvit force-pushed the sdwvit/feature/attack-protection/add-suspious-ip-methods branch from 913ba6c to b2eb94a Compare October 20, 2021 15:35
@sdwvit sdwvit marked this pull request as ready for review October 20, 2021 15:36
@sdwvit sdwvit requested a review from a team as a code owner October 20, 2021 15:36
- fix mock data to look like real suspicious IP throttling config
@sdwvit
Copy link
Contributor Author

sdwvit commented Oct 21, 2021

@adamjmcgrath thank you! Please feel free to merge the pr

@adamjmcgrath adamjmcgrath merged commit 28e7670 into auth0:iamrisk-1268 Oct 21, 2021
This was referenced Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants