Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAUTH-1274]: feat(attack protection): add breached password detection endpoints #676

Conversation

sdwvit
Copy link
Contributor

@sdwvit sdwvit commented Nov 1, 2021

Changes

Adding 2 new endpoints:

  • GET /api/v2/attack-protection/breached-password-detection

    • mng.attackProtection.getBreachedPasswordDetectionConfig(params, callback)
    • params is always an empty {} for now, since this endpoint does not support query parameters
  • PATCH /api/v2/attack-protection/breached-password-detection

    • mng.attackProtection.updateBreachedPasswordDetectionConfig(params, data, callback)
    • params is always an empty {} for now, since this endpoint does not support query parameters

These endpoint are not yet public, but stable and merged into a iam risk feature branch of api2.

References

Screen Shot 2021-11-01 at 5 13 48 PM

Testing

  • This change was manually tested
  • This change adds unit test coverage

Checklist

attack-protection.tests.js:
- add breached password detection methods
@sdwvit sdwvit requested a review from a team as a code owner November 1, 2021 21:12
Victor Musiienko added 2 commits November 1, 2021 17:18
- bad copypaste in previous pr
@sdwvit sdwvit changed the title [CAUTH-1273]: feat(attack protection): add breached password detection endpoints [CAUTH-1274]: feat(attack protection): add breached password detection endpoints Nov 1, 2021
Copy link

@josh-cain josh-cain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdwvit
Copy link
Contributor Author

sdwvit commented Nov 2, 2021

@adamjmcgrath please feel free to merge

@adamjmcgrath adamjmcgrath merged commit b68c4b5 into auth0:iamrisk-1268 Nov 2, 2021
This was referenced Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants