Check payload is not null when decoded. (#444)

* Check payload is not null when decoded. Fixed "Cannot read property 'nbf' of null" * Condition on obj !== null for clarity * Added test for decoding null token
auth0 · Apr 5, 2018 · 1232ae9 · 1232ae9
1 parent e8ac1be
commit 1232ae9
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/decode.js b/decode.js
@@ -10,7 +10,7 @@ module.exports = function (jwt, options) {
   if(typeof payload === 'string') {
     try {
       var obj = JSON.parse(payload);
-      if(typeof obj === 'object') {
+      if(obj !== null && typeof obj === 'object') {
         payload = obj;
       }
     } catch (e) { }

diff --git a/test/decoding.tests.js b/test/decoding.tests.js
@@ -0,0 +1,12 @@
+var jwt = require('../index');
+var expect = require('chai').expect;
+var atob = require('atob');
+
+describe('decoding', function() {
+
+  it('should not crash when decoding a null token', function () {
+    var decoded = jwt.decode("null");
+    expect(decoded).to.equal(null);
+  });
+
+});