Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put error in callback in node style #178

Closed
RohovDmytro opened this issue Feb 23, 2016 · 1 comment
Closed

Put error in callback in node style #178

RohovDmytro opened this issue Feb 23, 2016 · 1 comment

Comments

@RohovDmytro
Copy link

Current state:

jwt.sign({ foo: 'bar' }, cert, { algorithm: 'RS256' }, function(token) {});

Why not?

jwt.sign({ foo: 'bar' }, cert, { algorithm: 'RS256' }, function(err, token) {});

Will it be too breaking change to implement?
@jfromaniello
Copy link
Member

yes, this is a duplicated of #169 .

I will fix this on the next major release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jfromaniello @RohovDmytro