Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign callback function is called with successful result as a first argument #169

Closed
jeanadrien opened this issue Jan 21, 2016 · 4 comments
Closed

Comments

@jeanadrien
Copy link

But, as a node.js developer I would conventionally expect an error as a first argument, and a success as a second argument.

@jfromaniello
Copy link
Member

I plan to address this on next major version

@Deadarius
Copy link

👍 this one, I am using promisify-node library to make it return promise and it actually took me awhile to realise what is going on 😆

@pioneerroad
Copy link

+1 I'm also using a promise library and took me ages to work out why the promise was resolving as an error.

@jfromaniello
Copy link
Member

fixed in v6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants