always use jws.sign such that errors can be at all handled #165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches
sign
to always usejws#sign
instead of the streaming interface. Why?error
events from the stream, howevercallback
is not an errback (oops!), as such the only way to actually catch/handle errors if for them to throw synchronously - and thus we need to use the more-synchronous method.jws#sign
anyway, after buffering input data. In this case, all inputs are already known (and small), meaning the streaming interface just adds overheadverify
is an errback!)