Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull Request #374 has broken the use of the 'none' algorithm. #381

Closed
rhysmccaig opened this issue Aug 11, 2017 · 0 comments
Closed

Pull Request #374 has broken the use of the 'none' algorithm. #381

rhysmccaig opened this issue Aug 11, 2017 · 0 comments

Comments

@rhysmccaig
Copy link

rhysmccaig commented Aug 11, 2017 •
edited
Loading

Noticed this in my own test cases - when using the none algorithm the sign() function now throws an error if a secret isn't defined. (which is find for alg: none)

I believe the simple workaround which preserves the workaround added in #374 is to simply set the secretOrPrivateKey to any string when the algorithm is set to none. Will add a PR shortly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rhysmccaig