sign: add check to be sure secret has a value #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This breaks the use of the none algorithm. |
|
@rhysmccaig The workaround is to pass in a non-zero length string. Not ideal behavior, but it unblocks you when using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lately there are more people raising this, not big deal but it can be weird and create confusion. We fix it in our layer, since the bug in JWS is still open.
In case of sync call, with current master code this error is returned:
TypeError: secret must be a string or buffer.With this PR both will return the same error
Error: secretOrPrivateKey must have a value, I don't think the change would break anyone, because if someone got that error their integration would not be working at all.Fixes: #286
Fixes: #373