Not Before (nbf) calculated based on iat/timestamp #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziluvatar
reviewed
Jan 19, 2018
test/iat.tests.js
Outdated
| var token = jwt.sign({foo: 123, iat: iat}, '123', {notBefore: notBefore}); | ||
| var result = jwt.verify(token, '123'); | ||
| expect(result.nbf).to.be.closeTo(iat + notBefore, 0.2); |
There was a problem hiding this comment.
since the timestamp will be the iat, shouldn't it be equal always (instead of "closeTo")
There was a problem hiding this comment.
I agree completely! I was following the previous test example to keep the style the same, but I will gladly update.
There was a problem hiding this comment.
Changed to check for direct equals.
ziluvatar
approved these changes
Jan 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #435
Set nbf value based on the timestamp.