Refactor sign validation tests #493
Conversation
The validation tests for the sign method were spread across multiple files, this change brings them together into a single file. Additional tests and improvements are also made to ensure that all the validation options are fully tested.
MitMaro
force-pushed
the
sign-validation-test-refactor
branch
from
741e11f to
1848bd5
Compare
|
One doubt that I have is: Imagine I want to add a new feature, that has a new option that has some validation and some other code to perform the business actions, with this approach I would need to write the validation test here (in the new file) and the business testing in the feature test file. Isn't it better to have tests by functionality? and inside of it all the needed tests: validation for its options, errors, outputs, etc? Like This way tests are self-contained by functionality. Thoughts? |
|
Understandable concerns, and I agree with the point. Let me try something that tackles it from the perspective of a use case. It might mean some minor overlap in the tests, but I don't think that is a bad thing in this case. The tests in this PR should still be needed, it's just a question of the structure. |
|
I'll reject this PR, and leave a comment on the issue for this proposal. |
This gives an idea of what I was thinking of for my proposal in #492. This would be the first of several PRs that I would like to create that would cleanup and complete the tests.
Description
The validation tests for the sign method were spread across multiple files, this change brings them together into a single file. Additional tests and improvements are also made to ensure that all the validation options are fully tested.