Refactor tests related to notBefore and nbf (#492) #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change extracts all tests in the current files related to notBefore and nbf into a single test file. It also adds several missing related tests.
MitMaro
force-pushed
the
sign-validation-test-refactor
branch
from
233449a to
9179675
Compare
|
Noticed I forgot to rename the branch, I will recreate the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR for #492.
This change extracts all tests in the current files related to
notBeforeandnbfinto a single test file. It also adds several missing related tests.I believe I removed all references to
nbfandnotBeforefrom the current tests.There are two TODOs in the tests, because I found a few unhandled cases that I expected would cause an error but did not. They are:
notBefore. I'm not sure if this should default to0or should throw an error. Currently it throws aval is not a non-empty string or a valid number. val=""fromms.-Infinity,InfinityandNaNtonbf. These allJSON.stringifytonull, so I would assume should be considered invalid.Any suggestions of missing tests are more than welcome, and I will gladly add!