Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests related to iss and issuer #543

Merged
merged 1 commit into from
Nov 2, 2018

Conversation

MitMaro
Copy link
Contributor

@MitMaro MitMaro commented Oct 24, 2018

Next PR for #492

This change extracts all tests in the existing test files related to issuer and iss into a single test file. Several other tests are also added that were missing from the existing files.

All references to issuer and iss have been removed from the existing test files.

As always, suggestions or missing tests are more than welcome!

Coverage Master

=============================== Coverage summary ===============================
Statements   : 97.07% ( 232/239 )
Branches     : 97.57% ( 201/206 )
Functions    : 100% ( 23/23 )
Lines        : 97.46% ( 230/236 )
================================================================================

Coverage Branch

=============================== Coverage summary ===============================
Statements   : 97.07% ( 232/239 )
Branches     : 97.57% ( 201/206 )
Functions    : 100% ( 23/23 )
Lines        : 97.46% ( 230/236 )
================================================================================

This change extracts all tests related to the iss claim and the issuer
option into a single test file. Additional tests were added that were
missing.
@ziluvatar ziluvatar merged commit 0906a3f into auth0:master Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants