Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node: prefix #970

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jordanfinners
Copy link

@jordanfinners jordanfinners commented May 26, 2024

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Add prefix to nodejs dependencies to support running in Node and Cloudflare environments

References

https://developers.cloudflare.com/workers/runtime-apis/nodejs/

Also changed this in the dependencies:
auth0/node-jwa#50
auth0/node-jws#110

Testing

This will break older node versions, which do not support this syntax. This goes back to Node 14

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

* Add prefix to nodejs dependencies to support running in Node and Cloudflare environments
https://developers.cloudflare.com/workers/runtime-apis/nodejs/
@CharlesRea
Copy link

@jordanfinners - thanks for raising this, and for waiting for a response. The change looks good; we are going to bundle it into an upcoming major version release at same time as dropping support for older end-of-life Node versions.

Note that we'll also be including #978 in the upcoming major version, which removes dependency on jwa and jws, so will avoid the need for releasing the change to those libs.

As a heads up, CI is currently failing on this PR due to older Node versions, so will hold off on merging until we have shipped a change shortly to remove the outdated Node versions from CI - will merge and approve once that's done.

@jordanfinners
Copy link
Author

@CharlesRea oh awesome! Thank you!
Do you have a rough idea on when the next major release will be?

For the PRs in jwa and jws do you want me to close those off if you aren't going to need them here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants