Feature/async strategies (update #1) #89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
D1plo1d
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request brings the async fork for signing on hardware security modules ( #74 ) up to date with the latest auth0/node-saml master. From the original pull request:
Allow the user of the library to specify a signing or encryption strategy externally. Useful when signing keys are in remote servers or HSM devices and signing must happen async or with the use of custom APIs.
Testing
[ x ] This change adds test coverage for new/changed/fixed functionality
Checklist
[ x ] I have added documentation for new/changed functionality in this PR or in auth0.com/docs
[ x ] All active GitHub checks for tests, formatting, and security are passing
[ x ] The correct base branch is being used, if not master