Silent authentication #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user add prompt param to the request query string, then the authorize_params method will consider this param when making the request_phase url.
|
@batalla3692 - Thank you for the PR and apologies for the delay in response here (did not have notifications setup but I do now). I have a quick piece of feedback that I'll post as a review, otherwise this looks fine. |
joshcanhelp
suggested changes
Aug 15, 2018
.gitignore
Outdated
| tmp/ | ||
| .idea |
There was a problem hiding this comment.
IDE files should be in a global .gitignore:
https://help.github.com/articles/ignoring-files/#create-a-global-gitignore
|
Thanks @joshcanhelp, I remove that rule from .gitignore |
This ignore rules must live in ~/.gitignore_global
danielbatallaq
force-pushed
the
silent-authentication
branch
from
19ffe6a
to
710d082
Compare
joshcanhelp
approved these changes
Aug 22, 2018
|
Thanks @batalla3692! I'll merge this now and release it as soon as possible. We're working on getting ID token validation in for the next release so it will be bundled with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add silent authentication functionality
Now you can pass
promptparameter inredirect_topath, andauthorize_paramsmethod will add it to the authorization params.Closes #58