Fix Rubocop errors #66
Conversation
|
@machuga - If you have a few minutes, would you mind taking a look here? Just code style and minor changes to affect method length/complexity 🙌 |
| @@ -19,8 +19,8 @@ group :test do | |||
| gem 'listen', '~> 3.1.5' | |||
| gem 'rack-test' | |||
| gem 'rspec', '~> 3.5' | |||
| gem 'rubocop', '>= 0.30', platforms: [ | |||
| :ruby_19, :ruby_20, :ruby_21, :ruby_22 | |||
There was a problem hiding this comment.
https://www.ruby-lang.org/en/downloads/branches/ I don't see any of the current versions of Ruby (>= 2.3) available in this list. Not within scope of this PR, just something to point out
| # | ||
| # Reused data | ||
| # | ||
|
|
||
| let(:client_id) { 'CLIENT_ID' } | ||
| let(:client_secret) { 'CLIENT_SECRET' } | ||
| let(:domain) { 'samples.auth0.com' } | ||
| let(:future_timecode) { 32503680000 } | ||
| let(:past_timecode) { 303912000 } | ||
| let(:future_timecode) { 32_503_680_000 } |
| @@ -234,10 +233,10 @@ | |||
| def make_jwt_validator(opt_domain = domain) | |||
| options = Struct.new(:domain, :client_id, :client_secret) | |||
There was a problem hiding this comment.
Since this is a struct/class it should be capitalized. Isn't this struct already available in this lib or is that in a different one?
There was a problem hiding this comment.
You may also want to hoist this out of this function because you're creating a new Struct type for this every invocation rather than creating an instance every time.
Options = Struct.new(...)
def make_jwt_validator(opt_domain = domain)
OmniAuth::Auth0::JWTValidator.new(
Options.new(opt_domain, client_id, client_secret)
)
end
There was a problem hiding this comment.
This is mocking a struct created in OmniAuth.
Good feedback on the hoisting
|
@machuga - Fixed up, passing Rubocup and tests 👍 |
Ran:
... then manually fixed the remaining 3.