Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security Fix on XPath searches + extra validations to avoid wrapping attacks #65

Merged
merged 4 commits into from
Nov 21, 2017
Merged

Security Fix on XPath searches + extra validations to avoid wrapping attacks #65

merged 4 commits into from
Nov 21, 2017

Conversation

ziluvatar
Copy link
Contributor

@ziluvatar ziluvatar commented Nov 21, 2017 •
edited
Loading

Fixes:

  • XPath
    • Selections on the assertion were not using relative paths, now they do.
  • Element Validations
    • Response must exist and appear only once.
    • Assertion is optional, when present, it appears only once.

For reviewer: squash and merge if possible.

@glena
Copy link
Contributor

glena commented Nov 21, 2017

LGTM

@ziluvatar ziluvatar mentioned this pull request Nov 21, 2017
Closed
@glena glena merged commit 2ec5bd2 into auth0:master Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glena glena glena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ziluvatar @glena