Update dependencies and enhance webAuth methods to support HTTPS #1125

subhankarmaiti · 2025-04-07T05:05:11Z

Changes

Update dependencies and enhance webAuth methods to support HTTPS

References

Changes made to support Auth0.swift changes

Checklist

I have read the Auth0 general contribution guidelines
All existing and new tests complete without errors
All active GitHub checks have passed

…eychain dependencies

…into SDK-5760

Copilot

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (2)

ios/A0Auth0.m: Language not supported
ios/NativeBridge.swift: Language not supported

src/webauth/agent.ts

pmathew92 · 2025-04-07T06:11:36Z

src/webauth/agent.ts

@@ -113,13 +117,17 @@ class Agent {
    );
    let redirectUri =
      options.returnToUrl ?? this.callbackUri(parameters.domain, scheme);
+
+    // Determine if we should use HTTPS
+    const useHTTPS = scheme.startsWith('https');


Is passing customeScheme only way the user can set https scheme ?

yes keeping same implementation fro android and iOS.

A0Auth0.podspec

Widcket · 2025-04-11T09:24:26Z

EXAMPLES.md

-  - [Accept user invitations](#accept-user-invitations)
- [Bot Protection](#bot-protection)
- [Domain Switching](#domain-switching)
+- [Examples using react-native-auth0](#examples-using-react-native-auth0)


The top-level link (the title) does not seem to be necessary.

This happened due to VS code auto format feature on save. Its updating my md file without any warning. Reverted back to prev.

Widcket · 2025-04-11T09:25:38Z

EXAMPLES.md

+Register https://yourdomain.com/{YOUR_APP_BUNDLE_ID}/{PLATFORM}/callback as an allowed callback URL in your Auth0 Dashboard
+Configure your app to handle Universal Links (iOS) and App Links (Android)
+Set up your domain with proper verification for these deep linking mechanisms


Suggested change

Register https://yourdomain.com/{YOUR_APP_BUNDLE_ID}/{PLATFORM}/callback as an allowed callback URL in your Auth0 Dashboard

Configure your app to handle Universal Links (iOS) and App Links (Android)

Set up your domain with proper verification for these deep linking mechanisms

1. Register https://yourdomain.com/{YOUR_APP_BUNDLE_ID}/{PLATFORM}/callback as an allowed callback URL in your Auth0 Dashboard.

2. Configure your app to handle Universal Links (iOS) and App Links (Android).

3. Set up your domain with proper verification for these deep linking mechanisms.

BTW, Auth0 already supports configuring (3) for the developer. They just need to configure some values in their Auth0 application's configuration on the Dashboard. We should mention this here and point to some docs pages with more specific instructions.

This also works with the tenant subdomain, eg. some-tenant.us.auth0.com

updated the examples.

…into SDK-5760

FAQ.md

Widcket · 2025-04-11T13:25:27Z

BTW, HTTPS callbacks should be the default and recommended option for Web Auth on iOS, so the README setup instructions should be updated accordingly. E.g.: https://github.com/auth0/Auth0.swift#configure-web-auth-ios--macos

Widcket · 2025-04-11T13:46:53Z

(after which the instructions on EXAMPLES.md will be redundant, so these should be removed)

Widcket · 2025-04-14T14:27:57Z

EXAMPLES.md

+
+1\. Register [https://yourdomain.com/{YOUR\_APP\_BUNDLE\_ID}/{PLATFORM}/callback](https://yourdomain.com/{YOUR_APP_BUNDLE_ID}/{PLATFORM}/callback) as an allowed callback URL in your Auth0 Dashboard
+2\. Configure your app to handle Universal Links \(iOS\) and App Links \(Android\)
+3\. Set up your domain with proper verification for these deep linking mechanisms


Set up your domain with proper verification for these deep linking mechanisms

This can be confusing for the customers, since this seems to imply that this requires a custom domain, when it's not the case. Also, we should link to proper documentation explaining how to do this setup. Otherwise, it's not really helpful.

BTW, this doesn't actually belong here. First, this is already being explained in the README's setup instructions. Second, this is inside the Authentication API's examples section, when it's about Web Auth.

So this should be removed.

Widcket · 2025-04-14T14:42:57Z

README.md

+```
+This configuration allows your iOS app to handle Universal Links properly.
+
+Refer to the example of [Using custom scheme for web authentication redirection](https://github.com/auth0/react-native-auth0/blob/master/EXAMPLES.md#using-custom-scheme-for-web-authentication-redirection)



This is missing the Configure the Team ID and bundle identifier part, as explained here: https://github.com/auth0/Auth0.swift#configure-the-team-id-and-bundle-identifier

I understand that it's explained in https://auth0.com/docs/get-started/applications/enable-universal-links-support-in-apple-xcode, but we should minimize the levels of indirection for essential setup instructions.

… App Links support

Update dependencies and enhance webAuth methods to support HTTPS

cc40a6d

subhankarmaiti requested a review from a team as a code owner April 7, 2025 05:05

subhankarmaiti added 2 commits April 7, 2025 10:36

Update Podfile.lock to upgrade A0Auth0, Auth0, JWTDecode, and SimpleK…

89a8a8e

…eychain dependencies

Merge branch 'master' of https://github.com/auth0/react-native-auth0 …

922c92f

…into SDK-5760

subhankarmaiti requested a review from Copilot April 7, 2025 05:11

Copilot AI reviewed Apr 7, 2025

View reviewed changes

pmathew92 reviewed Apr 7, 2025

View reviewed changes

src/webauth/agent.ts Outdated Show resolved Hide resolved

pmathew92 reviewed Apr 7, 2025

View reviewed changes

Widcket reviewed Apr 11, 2025

View reviewed changes

A0Auth0.podspec Show resolved Hide resolved

Widcket reviewed Apr 11, 2025

View reviewed changes

Widcket and others added 4 commits April 11, 2025 10:29

Merge branch 'master' into SDK-5760

a3705c4

call usehttps from native

888051a

Update FAQ.md

e535e29

Merge branch 'SDK-5760' of https://github.com/auth0/react-native-auth0 …

3973f8e

…into SDK-5760

Widcket reviewed Apr 11, 2025

View reviewed changes

FAQ.md Outdated Show resolved Hide resolved

subhankarmaiti added 2 commits April 14, 2025 19:11

update README and FAQ for callback URL recommendations

3d1ff6e

update expiration dates for ignored Snyk issues

ec5b785

Widcket reviewed Apr 14, 2025

View reviewed changes

Update documentation for callback URL recommendations and add Android…

76a62d4

… App Links support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update dependencies and enhance webAuth methods to support HTTPS #1125

Update dependencies and enhance webAuth methods to support HTTPS #1125

subhankarmaiti commented Apr 7, 2025 •

edited

Loading

Copilot AI left a comment

pmathew92 Apr 7, 2025

subhankarmaiti Apr 14, 2025

Widcket Apr 11, 2025

subhankarmaiti Apr 14, 2025

Widcket Apr 11, 2025

Widcket Apr 11, 2025

Widcket Apr 11, 2025

subhankarmaiti Apr 14, 2025

Widcket commented Apr 11, 2025

Widcket commented Apr 11, 2025

Widcket Apr 14, 2025

Widcket Apr 14, 2025

Widcket Apr 14, 2025

Widcket Apr 14, 2025

Update dependencies and enhance webAuth methods to support HTTPS #1125

Are you sure you want to change the base?

Update dependencies and enhance webAuth methods to support HTTPS #1125

Conversation

subhankarmaiti commented Apr 7, 2025 • edited Loading

Changes

References

Checklist

Copilot AI left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Widcket commented Apr 11, 2025

Widcket commented Apr 11, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

subhankarmaiti commented Apr 7, 2025 •

edited

Loading