Skip to content

Conversation

subhankarmaiti
Copy link
Contributor

@subhankarmaiti subhankarmaiti commented Jul 15, 2025

What

Fixes the ephemeralSession parameter type conversion in the iOS native webAuth method implementation.

Why

The ephemeralSession parameter was being passed directly as an NSNumber to the native bridge without proper boolean conversion. This could cause issues when the native Swift code expects a proper boolean value.

How

  • Added explicit boolean conversion using [ephemeralSession boolValue] before passing to the native bridge
  • This ensures the parameter is properly converted from NSNumber to BOOL type as expected by the Swift implementation

Testing

  • Verified that ephemeralSession: true works correctly on iOS
  • Verified that ephemeralSession: false works correctly on iOS
  • Confirmed no regression in existing webAuth functionality

Fixes #1232

@subhankarmaiti subhankarmaiti marked this pull request as ready for review July 15, 2025 16:32
@subhankarmaiti subhankarmaiti requested a review from a team as a code owner July 15, 2025 16:32
@subhankarmaiti subhankarmaiti merged commit 90da85a into master Jul 16, 2025
4 checks passed
@subhankarmaiti subhankarmaiti deleted the fix/SDK-6232-ios-ephemeral-session-type-conversion branch July 16, 2025 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Previous Google social login not shown as of 5.0.0-beta.3

2 participants