fix(iOS): Fix ephemeralSession parameter type conversion in webAuth #1238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes the
ephemeralSession
parameter type conversion in the iOS native webAuth method implementation.Why
The
ephemeralSession
parameter was being passed directly as anNSNumber
to the native bridge without proper boolean conversion. This could cause issues when the native Swift code expects a proper boolean value.How
[ephemeralSession boolValue]
before passing to the native bridgeNSNumber
toBOOL
type as expected by the Swift implementationTesting
ephemeralSession: true
works correctly on iOSephemeralSession: false
works correctly on iOSFixes #1232