Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disable sign out field to SAMLP connection options #204

Merged
merged 4 commits into from
Jul 6, 2022

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Jun 28, 2022

Description

As noted in #161 , the disableSignout SAMLP connection field is absent from management in both the Go SDK and Terraform provider. This PR builds off the Go SDK PR counterpart to implement into the provider.

Checklist

Note: Checklist required to be completed before a PR is considered to be reviewable.

Auth0 Code of Conduct

Auth0 General Contribution Guidelines

Changes include test coverage?

  • Yes
  • Not needed

Does the description provide the correct amount of context?

  • Yes, the description provides enough context for the reviewer to understand what these changes accomplish

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed

Is this code ready for production?

  • Yes, all code changes are intentional and no debugging calls are left over

@willvedd willvedd requested a review from a team as a code owner June 28, 2022 19:45
Copy link
Contributor

@sergiught sergiught left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻 great work. Will wait to approve this until we have a released version on the go SDK with this.

@sergiught sergiught marked this pull request as draft July 5, 2022 18:38
@sergiught sergiught force-pushed the add-disableSignout-field branch from 0e322a9 to a88f0b8 Compare July 6, 2022 09:29
@sergiught sergiught marked this pull request as ready for review July 6, 2022 09:33
@sergiught sergiught merged commit 15a253f into main Jul 6, 2022
@sergiught sergiught deleted the add-disableSignout-field branch July 6, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants