-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add_menu_page/admin_menu conflicts with other plugins. #37
Comments
mikemcguire
changed the title
Conflicts with other plugins.
add_menu_page/admin_menu conflicts with other plugins.
Jan 26, 2015
thx @mikemcguire, we'll take a look |
I set up a priority with decimals hoping it wont get overridden by other plugin. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I was having issues where the menu page would not be linked inside of the admin navigation. In particular I found this issue was happening when ACF Pro was activated http://www.advancedcustomfields.com/ I tried to track down where the conflict was happening and found that if I prevented ACF from generating it's menu page the auth0 menu page link appeared.
Considering that ACF is one of the most popular plugins for wordpress I thought it would reasonable that both plugins should work together.
When comparing the method that each plugin creates it's admin page, I found that both plugins were in fact using the correct action "admin-menu" to hook into, but ACF has set it's priority and accepted arguments whereas wp-auth0 used the defaults.
Here is ACF's action
And now wp-auth0's
If I add a priority to wp-auth0 of 99+ the conflict resolves itself. Or if I remove the priority argument from ACF the conflict resolves itself. I am not positive what is best practice here, to use the defaults or set a custom priority. I will post a duplicate issue one the ACF plugin github, so that hopefully these types of conflicts can be avoided.
The text was updated successfully, but these errors were encountered: