Implement Pre-Authenticated URL #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tung2744
changed the title
|
Finished renaming. |
Merged
sdk/src/main/java/com/oursky/authgear/PersistentSharedStorage.kt
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,12 @@ | |||
| package com.oursky.authgear | |||
|
|
|||
| sealed class AppInitiatedSSOToWebNotAllowedException : AuthgearException { | |||
There was a problem hiding this comment.
Do not use sealed class in public API. I do not know how is it translated to Java. Just use normal class hierarchy to represent these exceptions.
There was a problem hiding this comment.
https://medium.com/asos-techblog/kotlin-classes-in-java-world-365323843e6e
It will be something like
abstract class PreAuthenticatedURLNotAllowedException {
static final class InsufficientScopeException extends PreAuthenticatedURLNotAllowedException {
}
static final class IDTokenNotFoundException extends PreAuthenticatedURLNotAllowedException {
}
static final class DeviceSecretNotFoundException extends PreAuthenticatedURLNotAllowedException {
}
}I've added a commit to ensure it can be imported in java.
There was a problem hiding this comment.
But exception as a inner class in uncommon. I still prefer we use regular classes.
There was a problem hiding this comment.
@louischan-oursky Added a commit to change it to regular classes.
|
@tung2744 Please ping me when this PR is ready for review again. |
|
@louischan-oursky Updated, thanks! |
louischan-oursky
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref DEV-1407
Test steps are same as authgear/authgear-sdk-js#306