Workaround for DEV-1351 #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is unnecessary. We haven't add the web view to the parent yet.
tung2744
reviewed
Aug 12, 2024
Comment on lines
+90
to
+96
| // This flag is used to work around an issue of fragment re-creation. | ||
| // When this fragment is used with androidx.navigation, | ||
| // this fragment may be onDestroyView(), and then onCreateView() again. | ||
| // If that happens, the webView may never has its load() called. | ||
| // However, even with this fix, savedInstanceState was never called, so | ||
| // the webView will show the initial screen. | ||
| private var waitWebViewToLoadIsCalledInThisLifecycle: Boolean = false |
There was a problem hiding this comment.
Does it means sometimes onDestroyView will be called but onSaveInstanceState won't call?
There was a problem hiding this comment.
According to https://developer.android.com/guide/fragments/lifecycle#states
onSaveInstanceState is always called before calling onDestroyView
So on onCreateView the webview should be able to restore the state 🤔
tung2744
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref DEV-1351