Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old rate limits config after new rate limit is deployed #3098

Open
Tracked by #3013 ...
fungc-io opened this issue May 16, 2023 · 5 comments
Open
Tracked by #3013 ...

Remove old rate limits config after new rate limit is deployed #3098

fungc-io opened this issue May 16, 2023 · 5 comments
Assignees

Comments

@fungc-io
Copy link
Member

fungc-io commented May 16, 2023

@louischan-oursky
Copy link
Collaborator

We can schedule this task now.

@fungc-io
Copy link
Member Author

fungc-io commented Jul 6, 2023

same as #3066?

@louischan-oursky
Copy link
Collaborator

No. This issue is about removing the deprecated configuration fields from the configuration file schema. After this change, any configuration file still containing the removed fields will be considered as invalid.

@tung2744
Copy link
Contributor

tung2744 commented Nov 14, 2023

We will run the migration script again after this cooldown, and observe if any invalid configs exist in next cooldown.

Run migration:

  • Staging
  • Production

Run check in next cooldown:

  • Staging
  • Production

@tung2744
Copy link
Contributor

tung2744 commented Dec 21, 2023

Checked in staging and there are still deprecated configs, need to check again where it comes from..
Or maybe we should modify the pr so it removes deprecated configs by using this style:
#3524

louischan-oursky added a commit that referenced this issue Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants