Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISS-310 - [IN PROGRESS] added PATCH support for mock maker #315

Merged
merged 3 commits into from
Sep 20, 2019
Merged

ISS-310 - [IN PROGRESS] added PATCH support for mock maker #315

merged 3 commits into from
Sep 20, 2019

Conversation

authorjapps
Copy link
Owner

updated junit test for PATCH,
updated test scenario json with PATCH example

@BeTheCodeWithYou
added PATCH support for mock maker,
57dbc0c 
updated junit test for PATCH,
updated test scenario json with PATCH example
officiallysameer
officiallysameer approved these changes Sep 20, 2019
View reviewed changes
Copy link
Collaborator

@officiallysameer officiallysameer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Neeraj, the implementation looks good. You can proceed with the DELETE operation

BeTheCodeWithYou and others added 2 commits September 20, 2019 17:59
@BeTheCodeWithYou
added DELETE support for mock maker,
326c86c 
updated junit test for DELETE,
updated test scenario json with DELETE example,

tidy up test class. Moved common code of all test to @begin
Merge branch 'master' into ISSUE-310_#_PATCH_support_in_MockMaker
60383e7
@BeTheCodeWithYou
Copy link
Collaborator

BeTheCodeWithYou commented Sep 20, 2019 •
edited
Loading

@officiallysameer Thanks Sameer. Yes updated PR with DELETE operation along with tidy up test cases.

@BeTheCodeWithYou BeTheCodeWithYou merged commit 5c85e3d into master Sep 20, 2019
@authorjapps
Copy link
Owner Author

solves #310

@authorjapps
Copy link
Owner Author

A couple of observations- Please take care/fix them when you get chance.

  • Fix import *

import static com.github.tomakehurst.wiremock.client.WireMock.*;

  • An example e2e test in the http-testing module please. Under below package.

https://github.com/authorjapps/zerocode/tree/master/http-testing/src/test/resources/wiremock_tests

After the next version is released-

Please use the same test for HelloWorld project.

@authorjapps authorjapps mentioned this pull request Sep 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@officiallysameer officiallysameer officiallysameer approved these changes

@arunvelusamyd arunvelusamyd Awaiting requested review from arunvelusamyd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@authorjapps @BeTheCodeWithYou @officiallysameer