Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save macos keys in keychain under app.bundle.id #44

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

zeroflaw
Copy link

Issue: #43 (comment)

Removing keys in macOS is not obvious because they are not saved under the app.bundle.id. This pull request fixes that.

@zeroflaw zeroflaw mentioned this pull request Oct 20, 2021
@zeroflaw zeroflaw marked this pull request as draft October 20, 2021 21:21
@zeroflaw zeroflaw marked this pull request as ready for review October 20, 2021 21:33
@hpoul
Copy link
Collaborator

hpoul commented Oct 21, 2021

thanks for the PR, but this is a pretty heavy breaking change.. i think it would be better to allow configuration of the service name? (maybe keeping the default to flutter_biometric_storage 🤔️)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants